feat: adding version metadata to be able to specify kafka broker version #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Dorn-
force-pushed
the
feat/add-kafka-version-metadata
branch
from
2e3a843 to
80c06d7
Compare
zroubalik
reviewed
Jun 7, 2021
Signed-off-by: Flavien Chantelot <contact@flavien.dev>
Dorn-
force-pushed
the
feat/add-kafka-version-metadata
branch
from
80c06d7 to
ae9cfeb
Compare
This was referenced Aug 2, 2021
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
…ion (kedacore#1866) Signed-off-by: Flavien Chantelot <contact@flavien.dev> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a metadata
versionto be able to set the user's kafka version. Right now, the value is hardcoded to 1.0.0 when calling the samara library. This commit will let the user specify which kafka version he is using only if it is supported by samara.The PR updating the documentation will be submitted asap. To avoid any breaking changes, the default version is setted to 1.0.0 as before.
Checklist
See #1764
kedacore/keda-docs#464