Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(influxdb-scaler): add support for integer query results #1977

Merged
merged 4 commits into from
Aug 2, 2021
Merged

feat(influxdb-scaler): add support for integer query results #1977

merged 4 commits into from
Aug 2, 2021

Conversation

philomory
Copy link
Contributor

@philomory philomory commented Jul 22, 2021 •
edited by zroubalik
Loading

Signed-off-by: Adam Gardner adam.gardner@magicmemories.com

Adjusted the InfluxDB scaler so that it can successfully process queries that return integer results in addition to those that return float results.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #1973

@philomory
feat(influxdb-scaler): add support for integer query results
0633bd7 
Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
@zroubalik
Copy link
Member

@philomory could you please fix the linter problem? thx

@zroubalik zroubalik mentioned this pull request Jul 27, 2021
Closed
@yquansah
Copy link
Contributor

@philomory Yeah the linter problem the only hanging thing, other than that the PR looks good

@philomory
Copy link
Contributor Author

philomory commented Jul 28, 2021 •
edited
Loading

Due to an unexpectedly early family arrival, I'm not near a workstation and probably won't be for some time. I could theoretically make changes to the PR from my iPad, but of course I can't run the linter on the iPad and the workflow logs appear to have already been purged. If anyone wants to le me know what changes the linter is asking for I'd be happy to approve them (pre-emptively, even).

Edit: Ah, it seems like as I was typing this message, @ahmelsayed provided exactly the information I was looking for. Thanks!

Edit again: Oh, but now I can't sign-off on the new commit. That's unfortunate.

@philomory @ahmelsayed
Update pkg/scalers/influxdb_scaler.go
a26bcf2 
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
@ahmelsayed
Copy link
Contributor

@philomory sorry I missed a curly bracket :).
And no worries, enjoy family time!

@zroubalik
Copy link
Member

The DCO signoff can be fixed when merging this PR, it is not a problem.

@philomory @ahmelsayed
Update pkg/scalers/influxdb_scaler.go
6d93b9e 
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
@philomory @zroubalik
Update pkg/scalers/influxdb_scaler.go
1e17af8 
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
@zroubalik zroubalik merged commit 7e7d42b into kedacore:main Aug 2, 2021
@philomory philomory deleted the feature/influxdb-scaler/support-int-queries branch August 2, 2021 09:58
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
@philomory @ahmelsayed
@zroubalik @nilayasiktoprak
influxdb scaler: add support for integer query results (kedacore#1977)
786ac2d 
Signed-off-by: Adam Gardner <adam.gardner@magicmemories.com>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[InfluxDB Scaler] Allow queries that return integers in addition to those that return floats
4 participants
@philomory @zroubalik @yquansah @ahmelsayed