Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for configuring authentication through TriggerAuthentication for Stan scaler #2167

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

Ritikaa96
Copy link
Contributor

@Ritikaa96 Ritikaa96 commented Oct 7, 2021

Signed-off-by: Ritikaa96 ritika@india.nec.com

Related To:
#2166

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #2166

…ication for Stan scaler

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, could you please update docs and changelog?

@Ritikaa96
Copy link
Contributor Author

Looking good, could you please update docs and changelog?

@zroubalik sure thing 👍

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96
Copy link
Contributor Author

Hi @zroubalik, I've updated the docs and changelog.

@zroubalik zroubalik added this to the v2.5.0 milestone Oct 12, 2021
pkg/scalers/stan_scaler_test.go Outdated Show resolved Hide resolved
pkg/scalers/stan_scaler_test.go Outdated Show resolved Hide resolved
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96
Copy link
Contributor Author

@arschles @zroubalik PTAL

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 6dadf28 into kedacore:main Oct 13, 2021
nilayasiktoprak pushed a commit to nilayasiktoprak/keda that referenced this pull request Oct 23, 2021
…ication for Stan scaler (kedacore#2167)

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for configuring authentication through TriggerAuthentication for Stan scaler
3 participants