-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for configuring authentication through TriggerAuthentication for Stan scaler #2167
Provide support for configuring authentication through TriggerAuthentication for Stan scaler #2167
Conversation
…ication for Stan scaler Signed-off-by: Ritikaa96 <ritika@india.nec.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, could you please update docs and changelog?
@zroubalik sure thing 👍 |
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
Hi @zroubalik, I've updated the docs and changelog. |
Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@arschles @zroubalik PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…ication for Stan scaler (kedacore#2167) Signed-off-by: Ritikaa96 <ritika@india.nec.com> Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Signed-off-by: Ritikaa96 ritika@india.nec.com
Related To:
#2166
Checklist
Fixes #2166