Add GCP identity authentication when using Pubsub Scaler #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne identity Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
jmalvarezf-lmes
requested review from
ahmelsayed and
zroubalik
as code owners
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
jmalvarezf-lmes
force-pushed
the
feature/gcp-identity
branch
from
f0f9fb3
to
3f2f52f
Compare
zroubalik
reviewed
Nov 3, 2021
Signed-off-by: Jose Maria Alvarez <jose-maria.alvarez@leroymerlin.es>
|
@zroubalik please check if everything is fine. Thank you! |
zroubalik
approved these changes
Nov 3, 2021
zroubalik
changed the title
|
You are welcome! |
|
Nice, thanks! |
1 task
|
Did I understand correctly how to use it (see docs I attempted to create)? |
|
@hermanbanken yes, that is the idea. We have it running like this in our environment. We do not use workload identity, but the functionality is exactly the same. |
|
I completely missed kedacore/keda-docs#565... 😅 |
|
@hermanbanken lol 😄 but would be nice if you can add your improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This tries to partially fix this issue: #2048. Basically the fix consist on using the gcp identity framework so that when you do a request to stackdriver to get the number of undelivered messages, you use the service account associated to the machine (GCE), instead of using a service account in a secret. That allows to use this very useful scaler without creating a service account and a secret and you can use a Cluster Trigger Authentication widely to use the underlying service account. I couldn't create tests, as this relies on being executed on GCP. But I've tested it in our environment and it works.
Hope it is useful for you.
I wait for you to check this, and if it is useful, and you agree, I will change the docs to adapt to this new method.
Regards,
Jose Maria.