Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate values length for prometheus scaler #2264

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Validate values length for prometheus scaler #2264

merged 3 commits into from
Nov 10, 2021

Conversation

sosoftmandruszak
Copy link
Contributor

@sosoftmandruszak sosoftmandruszak commented Nov 9, 2021 •
edited
Loading

Signed-off-by: Magdalena Andruszak mandruszak@gmail.com

Validating values length in prometheus query response. When there is no values returned invalid array index panic occurs.

Solution:

  • If there is no values in response return zero
  • If single value received return error

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated

Fixes #

@sosoftmandruszak
Validate values length for prometheus scaler
c5e6bac 
Signed-off-by: Magdalena Andruszak <mandruszak@gmail.com>
@sosoftmandruszak
Update changelog for values length validation of prometheus query res…
2fd9e7b 
…ponse

Signed-off-by: Magdalena Andruszak <mandruszak@gmail.com>
@sosoftmandruszak
Add prometheus scaler execute query tests
ede03c9 
Signed-off-by: Magdalena Andruszak <mandruszak@gmail.com>
@sosoftmandruszak sosoftmandruszak marked this pull request as ready for review November 9, 2021 15:31
@JorTurFer
Copy link
Member

/run-e2e prometheus*

@JorTurFer
Copy link
Member

LTGM!
The prometheus e2e tests are running, let's see the result :)

Thanks a ton for your contribution ❤️

@JorTurFer
Copy link
Member

/run-e2e prometheus.test*

zroubalik
zroubalik approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @sosoftmandruszak!

@zroubalik zroubalik merged commit cc95674 into kedacore:main Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sosoftmandruszak @JorTurFer @zroubalik