GCP Pub/Sub Scaler: add oldest unacked message age metric #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stackdriver and update tests Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
fira42073
force-pushed
the
feature/pubsub-oldestmessageage-scaler
branch
from
e722f61 to
cc89be6
Compare
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
zroubalik
changed the title
|
PR for documentation kedacore/keda-docs#579 |
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
added 2 commits
November 12, 2021 19:06
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
|
@jmalvarezf-lmes PTAL |
|
Hi @Friedrich42, For me it is fine, thank you! Regards, |
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
zroubalik
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Looking good, could you please update the Changelog as well?
https://github.com/kedacore/keda/blob/main/CHANGELOG.md#improvements
Unreleased->Improvements
tomkerkhove
suggested changes
Nov 16, 2021
zroubalik
requested changes
Nov 16, 2021
added 4 commits
November 18, 2021 13:10
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
…e field Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
tomkerkhove
reviewed
Nov 18, 2021
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
fira42073
force-pushed
the
feature/pubsub-oldestmessageage-scaler
branch
from
8a6454c to
95ecc7c
Compare
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
Signed-off-by: Friedrich Albert Kyuri <friedrichak42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ability to scale using oldest unacked message age metric from gcp stackdriver and update tests
Fixes #2226