-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve (azure-pipelines): log url on error #2297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for your contribution!
Only small nit
I'm going to look for more simple errors like that, and it helps me understand the code better. Edit: I make error with Signature, i will correct then. |
You need to amend the wrong commit, adding other one signed it's not enough. |
…rado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Enderson Menezes <endersonster@gmail.com>
9d35ecb
to
92e2abe
Compare
Like that? |
Yes, exactly like that :) Thanks a ton! |
Signed-off-by: Enderson Menezes <endersonster@gmail.com>
There is an error yet, could you take a look at it please? 🙏 |
Signed-off-by: Enderson Menezes <endersonster@gmail.com>
Sorry, i will install pre-commit and take more attention. |
Don't worry, It happens :) sorry for this because I didn't see it before: Apart from this, personally, I use dev containers in VS Code to avoid installing dependencies in my computer. KEDA supports it and pre-commit is already installed there. I prefer that than installing all dependencies for each project, maybe you'd like it BTW, thanks for the contribution ❤️ |
Signed-off-by: Enderson Menezes <endersonster@gmail.com>
i will read this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️❤️❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, added a question and would you mind updating the changelog please?
Signed-off-by: Enderson Menezes <endersonster@gmail.com>
Signed-off-by: Enderson Menezes <endersonster@gmail.com>
I don't understand why the "CI / Static Checks (pull_request) " failed :( |
I think that it was a random fail :( |
Signed-off-by: Enderson Menezes endersonster@gmail.com
Logging URL on Azure Pipelines Scaler Error!
Checklist
Hi, I'm new to Go and here at Keda we are running a POC within the company and this little addition helped us to better understand our mistake.
Does this change need to change CHANGELOG? Any other nonsense I've done let me know please!