-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign main tag and add missing env during release workflow #2502
Conversation
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is extra whitespace
I'm AFK, I'll update it in 40-50 min. |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
These f******* whitespaces... 🤣 🤣 🤣 |
@JorTurFer btw you can enable pre-commit locally, so you catch these kind of issues before commiting the actual code. |
I got it... but disabled because the tools are only installed inside the dev container, I should install them also in the host. Probably when my new computer arrives, I'll do something more reliable xD (usually I run it manually, but sometimes I forget it) Anyway, thanks for the suggestion ❤️ |
Signed-off-by: jorturfer jorge_turrado@hotmail.es
Checklist
Related #2501