Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging for errors when a blob container is not found in Azure event hubs scaler #2717

Merged
merged 8 commits into from
Mar 16, 2022
Merged

logging for errors when a blob container is not found in Azure event hubs scaler #2717

merged 8 commits into from
Mar 16, 2022

Conversation

sushmithavangala
Copy link
Contributor

@sushmithavangala sushmithavangala commented Mar 7, 2022 •
edited
Loading

Added logging for errors when a blob container is not found in Azure event hubs scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2363

@sushmithavangala sushmithavangala requested a review from a team as a code owner March 7, 2022 07:33
@sushmithavangala sushmithavangala changed the title Svangala eventhubs logging for errors when a blob container is not found in Azure event hubs scaler Mar 7, 2022
JorTurFer
JorTurFer reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution
Only small nit

pkg/scalers/azure_eventhub_scaler.go Outdated Show resolved Hide resolved
@sushmithavangala
Copy link
Contributor Author

Thanks for the contribution Only small nit

Modified the logging to use eventhubLog and combined the log messages too.

zroubalik
zroubalik reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the Changelog?

@sushmithavangala
Copy link
Contributor Author

Could you please also update the Changelog?

Done @zroubalik

@zroubalik
Copy link
Member

@SushmithaVReddy could you please rebase once again and move the Changelog entry to Improvements section?
Also could you please fix DCO? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

Then we can proceed with the merge, thanks!

sushmithavangala and others added 6 commits March 15, 2022 13:16
@sushmithavangala
Improved logging for blob container not found in event hub scaler
8bfb011 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@Photonios @sushmithavangala
Include vhost for RabbitMQ when retrieving queue info with useRegex (k…
0ea850c 
…edacore#2591)

Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@sushmithavangala
Modified Print method used for logging
e127447 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@sushmithavangala
using eventhublog for logging
242a948 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@sushmithavangala
corrected casing in log message
18190fa 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@sushmithavangala
added changes in changelog
b32748e 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@sushmithavangala
Copy link
Contributor Author

@SushmithaVReddy could you please rebase once again and move the Changelog entry to Improvements section? Also could you please fix DCO? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what

Then we can proceed with the merge, thanks!

Done @zroubalik

zroubalik
zroubalik reviewed Mar 15, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sushmithavangala
changelog improvements order fix
8637aa3 
Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
@zroubalik
Copy link
Member

Thanks @SushmithaVReddy !

@zroubalik zroubalik merged commit ef65f59 into kedacore:main Mar 16, 2022
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@sushmithavangala @Photonios @RamCohen
logging for errors when a blob container is not found in Azure event …
3fcb7a7 
…hubs scaler (kedacore#2717)

Signed-off-by: SushmithaVReddy <sushmithavangala@gmail.com>
Co-authored-by: Swen Kooij <swenkooij@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
@v-shenoy v-shenoy mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Event Hub scaler doesn't log anything if the blob container name is wrong
5 participants
@sushmithavangala @zroubalik @tomkerkhove @JorTurFer @Photonios