Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle restoreToOriginalReplicaCount if ScaleTarget is missing #2881

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Properly handle restoreToOriginalReplicaCount if ScaleTarget is missing #2881

merged 1 commit into from
Apr 4, 2022

Conversation

zroubalik
Copy link
Member

…is missing

Signed-off-by: Zbynek Roubalik zroubalik@gmail.com

Provide a description of what has been changed

Checklist

Fixes #2872

@zroubalik
Properly handle restoreToOriginalReplicaCount if ScaleTarget is m…
d821975 
…issing

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from a team as a code owner April 4, 2022 15:08
@JorTurFer
Copy link
Member

LGTM.
Is there any way to add at least one unit test?

@zroubalik
Copy link
Member Author

LGTM. Is there any way to add at least one unit test?

you are right, I will add some tests on this.

@zroubalik zroubalik merged commit 4cc10ae into kedacore:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEDA Operator crash with SO option restoreToOriginalReplicaCount
2 participants
@zroubalik @JorTurFer