Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid scaling triggered by events/messages when ScaledObject is paused #3011

Merged
merged 3 commits into from
May 10, 2022
Merged

Avoid scaling triggered by events/messages when ScaledObject is paused #3011

merged 3 commits into from
May 10, 2022

Conversation

aryan9600
Copy link
Contributor

@aryan9600 aryan9600 commented May 5, 2022 •
edited by JorTurFer
Loading

Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Fixes the issue of a ScaledObject scaling up/down based on the incoming events/messages when it's paused.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3009

@aryan9600 aryan9600 requested a review from a team as a code owner May 5, 2022 20:07
@zroubalik
Copy link
Member

zroubalik commented May 6, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@tomkerkhove
Copy link
Member

tomkerkhove commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e

Update: You can check the progres here

@zroubalik
Copy link
Member

zroubalik commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member

zroubalik commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member

zroubalik commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member

zroubalik commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@v-shenoy
Copy link
Contributor

v-shenoy commented May 9, 2022

@JorTurFer This seems to be caused by some updates to git and many issues being created as seen here.

I don't know too much about GitHub actions and runners to understand the issue here, but maybe you can understand better from these.

@JorTurFer
Copy link
Member

JorTurFer commented May 9, 2022 •
edited
Loading

wow, thanks a ton @v-shenoy , you have given to me the starting point. ❤️

@JorTurFer
Copy link
Member

JorTurFer commented May 9, 2022 •
edited
Loading

please @aryan9600 ,
rebase main into your branch, we have fixed the problem with e2e tests

@JorTurFer
Copy link
Member

JorTurFer commented May 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented May 10, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented May 10, 2022 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progres here

@JorTurFer
Copy link
Member

JorTurFer commented May 10, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

JorTurFer
JorTurFer approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️ ❤️

@JorTurFer
Copy link
Member

Could you update the changelog too please?

@aryan9600
exit early while scaling if the object is paused
031a453 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600
fix e2e tests for ensuring paused replicas dont scale
1ba981e 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600
update changelog
dd25114 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@JorTurFer JorTurFer merged commit 3cdac48 into kedacore:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pause autoscaling doesn't work from 0->1 or 1->0
5 participants
@aryan9600 @zroubalik @tomkerkhove @JorTurFer @v-shenoy