-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move account id to trigger auth on integration test for new relic #3027
test: move account id to trigger auth on integration test for new relic #3027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pragmaticivan it would be better if we create a separate test for this, instead of modifing the existing one. (The original approach is still valid imho).
Makes sense @zroubalik I actually just wanted to run that test in the CI, was not sure if integrations were triggered in PRs |
e2e test are not automatically triggered, but we can trigger them if you want |
/run-e2e new-relic* |
/run-e2e new-relic* |
@JorTurFer I'm suspecting my latest change was correct but was not passed down (omitting account ID for new relic). will try to investigate why. Hopefully I can get integration tests running in my machine soon. |
no no, the problem is in our cluster, 100% sure |
/run-e2e new-relic* |
Thanks @JorTurFer ! |
Moves account id to TriggerAuthentication for New Relic Integration Tests
Checklist
Relates to #2883