Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unify github actions workflow using multiarch image of build-tools #3131

Merged
merged 20 commits into from
Jul 15, 2022
Merged

fix: unify github actions workflow using multiarch image of build-tools #3131

merged 20 commits into from
Jul 15, 2022

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented Jun 6, 2022 •
edited by JorTurFer
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #3092

@xoanmm xoanmm requested a review from a team as a code owner June 6, 2022 19:47
@xoanmm xoanmm force-pushed the feature/update-github-actions-multiarch branch 2 times, most recently from a5b1652 to 62c7971 Compare June 6, 2022 20:52
JorTurFer
JorTurFer reviewed Jun 6, 2022
View reviewed changes
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
.github/workflows/pr-validation.yml Outdated Show resolved Hide resolved
@xoanmm xoanmm force-pushed the feature/update-github-actions-multiarch branch 4 times, most recently from 5ea7cfe to 576fd3b Compare June 7, 2022 18:29
@xoanmm xoanmm changed the title fix: unify validate-dev-container using multiarch fix: unify github actions workflow using multiarch image of build-tools Jun 8, 2022
@xoanmm xoanmm force-pushed the feature/update-github-actions-multiarch branch 2 times, most recently from 834f50e to 74f7145 Compare July 15, 2022 09:16
@xoanmm
Copy link
Contributor Author

xoanmm commented Jul 15, 2022

It's not possible use container with image ghcr.io/kedacore/build-tools:main in job validate-arm64 from main-build workflow due it's using kind and the tests are running inside a container, example of execution

xoanmm added 16 commits July 15, 2022 11:43
@xoanmm
fix: unify validate-dev-container using multiarch
f9ee19e 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: force to launch validate-dev-container job
0dffe0a 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: unify validate in one job
118bf9b 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: add matrix strategy to validate job
ced0a91 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: change matrix
6a584ca 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: correct matrix
231996f 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: change matrix adding attributes
7875b24 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: change name of jobs with matrix style
960e165 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: change name of matrix
ba78e28 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: correct typo
71789c0 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: add all elements to matrix
1a5b19b 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: simple change to trigger actions
11b2161 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: unify workflows
a6d4a43 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: remove innecesary step
218ebcc 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: make to launch all jobs
f8d2625 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: add test command to check change go version
a50d544 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
xoanmm added 4 commits July 15, 2022 11:43
@xoanmm
fix: remove unnecesary file
cdeb166 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: add test smoke arm
18fbc1c 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: delete innecesary line
2a743ce 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm
fix: delete container for smoke tests
9b5b29d 
Signed-off-by: Xoán Mallón <xoanmallon@gmail.com>
@xoanmm xoanmm force-pushed the feature/update-github-actions-multiarch branch from c104cf7 to 9b5b29d Compare July 15, 2022 09:43
@JorTurFer JorTurFer enabled auto-merge (squash) July 15, 2022 10:02
@JorTurFer JorTurFer merged commit 7c24d7b into kedacore:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoanmm @JorTurFer