Use go-install instead of go-get in Makefile

[davidlanouette]

Signed-off-by: David Lanouette David.Lanouette@RedHat.com

Use go-install instead of go-get to install dependencies (controller-gen, kustomize, etc)

go-install is the 'correct' way to install binaries in go 1.17 and later.

NOTE: using go-install requires updating the version of kustomize to v4 (v3 is not go-installable). If this isn't OK at this time, this PR should be rejected.

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• [N/A] Tests have been added
• [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• [N/A] A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Fixes #2916

[zroubalik]

Looking good, could you please confirm that it works for other go deps that use go-get-tool in the Makefile (controller-gen, envtest,...)?

[zroubalik]

/run-e2e azure*
Update: You can check the progress here

[davidlanouette]

could you please confirm that it works for other go deps that use go-get-tool in the Makefile (controller-gen, envtest,...)?

Hi @zroubalik

I ran it for all 4 dependencies and they all worked in both v1.17 and v1.18. I didn't try them in v1.16 or earlier.

[zroubalik]

could you please confirm that it works for other go deps that use go-get-tool in the Makefile (controller-gen, envtest,...)?

Hi @zroubalik

👋

I ran it for all 4 dependencies and they all worked in both v1.17 and v1.18. I didn't try them in v1.16 or earlier.

ack, thanks for confirmation!

[zroubalik]

LGTM, thanks for the contribution!