fix(kafka): Handle Sarama errors properly

[JorTurFer]

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

This PR adds extra traces to log Sarama errors but even they are errors that we aren't "catching" I haven't modified the behaviour to avoid breaking changes introduced by different error handling.

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• Changelog has been updated and is aligned with our changelog requirements

Fixes #3056

[JorTurFer]

Should I return them as regular errors and break the cycle instead of maintaining current behaviour?
WDYT @zroubalik ?

[JorTurFer]

/run-e2e kafka*
Update: You can check the progress here

[zroubalik]

Do you think you can try to get more detailed errors from the client creation?
Usually when there is a problem in conecting to Kafka Broker, there is just a generic error message stating, that client is not able to connect. Would be nice if we could get more detailed error info there.

[zroubalik]

Should I return them as regular errors and break the cycle instead of maintaining current behaviour? WDYT @zroubalik ?

As a first step, I'd try to get as much (error) information as possible without breaking the current behaviour.

[JorTurFer]

Do you think you can try to get more detailed errors from the client creation? Usually when there is a problem in conecting to Kafka Broker, there is just a generic error message stating, that client is not able to connect. Would be nice if we could get more detailed error info there.

checking

[JorTurFer]

AFAI can see, we can't get more info because client creation doesn't bring any KError, so we only can check the standard error.
I have tried creating an authorized broker and connecting KEDA without credentials and I can see the authentication errors (from Kerror) on the first call to the broker (not in the client creation but in the call to DescribeTopics)

[zroubalik]

AFAI can see, we can't get more info because client creation doesn't bring any KError, so we only can check the standard error. I have tried creating an authorized broker and connecting KEDA without credentials and I can see the authentication errors (from Kerror) on the first call to the broker (not in the client creation but in the call to DescribeTopics)

ack, thanks!

[zroubalik]

@JorTurFer please fix changelog and merge :)

[JorTurFer]

/run-e2e kafka*
Update: You can check the progress here