Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Metrics endpoint returns correct HPA value #3584

Merged
merged 7 commits into from
Aug 25, 2022
Merged

fix: Metrics endpoint returns correct HPA value #3584

merged 7 commits into from
Aug 25, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Aug 23, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3554

@JorTurFer
fix: Metrics endpoint returns correct value
beb7395 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add e2e test to validate the fix
a1485d3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner August 23, 2022 18:00
@JorTurFer
update message
f937aaf 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
rename e2e test
d526dc4 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
added condition to check array lenght
cc06036 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title fix: Metrics endpoint returns correct HPA value WIP fix: Metrics endpoint returns correct HPA value Aug 23, 2022
@JorTurFer
fix e2e test
ab62d33 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title WIP fix: Metrics endpoint returns correct HPA value fix: Metrics endpoint returns correct HPA value Aug 23, 2022
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 23, 2022 •
edited by github-actions bot
Loading

/run-e2e internals*
Update: You can check the progress here

@JorTurFer
fix styles
60b0522 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Aug 23, 2022 •
edited by github-actions bot
Loading

/run-e2e internals*
Update: You can check the progress here

zroubalik
zroubalik approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JorTurFer JorTurFer merged commit ef48177 into kedacore:main Aug 25, 2022
@JorTurFer JorTurFer deleted the metrics branch August 25, 2022 17:14
andyatwork pushed a commit to andyatwork/keda that referenced this pull request Oct 31, 2022
@andyatwork
fix: Metrics endpoint returns correct HPA value (kedacore#3584)
4c13644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/metrics (Prometheus) endpoint always returning a value of 0
2 participants
@JorTurFer @zroubalik