Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose trigger totals Prometheus metric in the operator pod #3695

Merged
merged 8 commits into from
Sep 29, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Sep 27, 2022

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3663

Relates to kedacore/keda-docs#945, kedacore/charts#317

@v-shenoy v-shenoy requested a review from a team as a code owner September 27, 2022 05:43
@v-shenoy v-shenoy changed the title Trigger totals Expose trigger totals Prometheus metric in the operator pod. Sep 27, 2022
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add e2e tests for this?

CHANGELOG.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Not sure about the best way to test here, but I'll try to see if I can do that.

if you are talking about tests here, I'd suggest to create x SO/SJ for which you know the triggers and just start scraping the metric.

@tomkerkhove
Copy link
Member

Let's collaborate on kedacore/charts#316 @v-shenoy

@v-shenoy
Copy link
Contributor Author

v-shenoy commented Sep 27, 2022

/run-e2e prometheus
Update: You can check the progress here

@v-shenoy
Copy link
Contributor Author

Can we add e2e tests for this?

Added @tomkerkhove @JorTurFer

@tomkerkhove tomkerkhove changed the title Expose trigger totals Prometheus metric in the operator pod. feat: Expose trigger totals Prometheus metric in the operator pod Sep 27, 2022
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Copy link
Contributor Author

Implemented it within the existing controllers. PTAL. @JorTurFer @zroubalik

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Sep 27, 2022

/run-e2e
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only one comment inline about e2e test

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 28, 2022

/run-e2e internal*
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JorTurFer JorTurFer merged commit 7b289e7 into kedacore:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide operational insights on # of triggers per trigger type
4 participants