-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Expose trigger totals Prometheus metric in the operator pod #3695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add e2e tests for this?
if you are talking about tests here, I'd suggest to create x SO/SJ for which you know the triggers and just start scraping the metric. |
Let's collaborate on kedacore/charts#316 @v-shenoy |
/run-e2e prometheus |
Added @tomkerkhove @JorTurFer |
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
2a7387e
to
628ba21
Compare
Implemented it within the existing controllers. PTAL. @JorTurFer @zroubalik |
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
628ba21
to
558dfdc
Compare
/run-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, only one comment inline about e2e test
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
/run-e2e internal* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Provide a description of what has been changed
Checklist
Fixes #3663
Relates to kedacore/keda-docs#945, kedacore/charts#317