Add support for tls in rabbitmq scaler (#967) #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
JorTurFer
reviewed
Jan 10, 2023
mohite-abhi
force-pushed
the
dev
branch
2 times, most recently
from
fe0dba5 to
25f93f9
Compare
JorTurFer
reviewed
Jan 12, 2023
|
Could you resolve the conflicts in the changelog please? Changes look good but CI checks are blocked |
JorTurFer
reviewed
Jan 16, 2023
|
There still are conflicts in CHANGELOG.md, could you fix them? 🙏 |
|
/run-e2e rabbit* |
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
Signed-off-by: Abhishek Mohite <b518004@iiit-bh.ac.in>
|
/run-e2e rabbit* |
JorTurFer
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Mohite b518004@iiit-bh.ac.in
Added tls support to rabbit mq with scaler configuration much like kafka. Checking if tls is enabled by using tls auth parameter. Calling DialTLS by passing tls auth parameters like ca, cert, key to it if tls is enabled.
Checklist
Fixes #
Solved error connecting to RabbitMQ host using certificate on using amqps.
Relates to #