Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage in pkg/util #4213

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Increase test coverage in pkg/util #4213

merged 5 commits into from
Feb 10, 2023

Conversation

dttung2905
Copy link
Contributor

Hi team,
This PR will increase the test coverage in pkg/util

Checklist

Fixes #3871

@dttung2905 dttung2905 requested a review from a team as a code owner February 8, 2023 15:05
@dttung2905 dttung2905 force-pushed the add-unittest-pkg-util branch from 04da438 to aa6760f Compare February 8, 2023 15:07
zroubalik
zroubalik reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

CHANGELOG.md Outdated Show resolved Hide resolved
@dttung2905
add tls_config_test.go file
e0b244e 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
add pkg/util/nomalize_string_test.go and add testcase with CACert
55271af 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Minor code review and fix CHANGELOG category
c40049d 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 force-pushed the add-unittest-pkg-util branch from 5045eb0 to c40049d Compare February 9, 2023 14:34
@dttung2905
Fix CHANGELOG file
eb5a2fd 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905
Fix static check
4b3e96a 
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
zroubalik
zroubalik approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

excellent, thanks a lot for the contribution!

@zroubalik zroubalik merged commit 7928860 into kedacore:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
skip-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase unit test coverage in pkg/util
2 participants
@dttung2905 @zroubalik