chore: Add logic to scale out/in the AKS cluster on every e2e test execution #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
changed the title
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
|
I skip e2e test because as the pipeline is executed from main branch, this PR can't be tests with the e2e tests (because the changes are in my branch and not in main branch) |
|
@tomkerkhove , @zroubalik , an ACK please? 🙏 |
|
I still need to review it, sorry! |
tomkerkhove
reviewed
Apr 25, 2023
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
tomkerkhove
approved these changes
May 2, 2023
2 tasks
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
May 2, 2023
geoffrey1330
pushed a commit
to geoffrey1330/keda
that referenced
this pull request
Oct 4, 2023
…ecution (kedacore#4456) Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reducing costs, this PR scales out the cluster to current nodes (4) before the tests execution and scales in the cluster again after them.
I have checked the
stopoption but based on documentation, we shouldn't stop/start the cluster too often, and we can execute several times the test in a row, stopping and starting the cluster in less than the recommended 15-30 minutes.As we cannot guarantee the period between stop/starts, I guess that it's better if we only reduce the cluster size.
This process increases the execution time 3-5 minutes per execution
Checklist