Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use azidentity for Azure Data Explorer #4490

Merged
merged 4 commits into from
May 15, 2023
Merged

chore: Use azidentity for Azure Data Explorer #4490

merged 4 commits into from
May 15, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented May 1, 2023 •
edited
Loading

Checklist

  • Changelog has been updated and is aligned with our [changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4489
Related to #4514

@JorTurFer JorTurFer requested a review from a team as a code owner May 1, 2023 11:00
@JorTurFer JorTurFer enabled auto-merge (squash) May 1, 2023 16:12
@JorTurFer JorTurFer changed the title chore: Use azidentity for Azure Data Explorer WIP - chore: Use azidentity for Azure Data Explorer May 1, 2023
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_data_explorer
Update: You can check the progress here

@JorTurFer JorTurFer disabled auto-merge May 1, 2023 17:48
@JorTurFer JorTurFer marked this pull request as draft May 1, 2023 17:50
@JorTurFer JorTurFer mentioned this pull request May 2, 2023
Merged
@JorTurFer
bump kusto SDK
d46daa1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update querying
f6e3395 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 2, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_data_explorer
Update: You can check the progress here

@JorTurFer
bump kust
d98839c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title WIP - chore: Use azidentity for Azure Data Explorer chore: Use azidentity for Azure Data Explorer May 9, 2023
@JorTurFer JorTurFer marked this pull request as ready for review May 9, 2023 19:13
@JorTurFer JorTurFer enabled auto-merge (squash) May 9, 2023 19:14
@JorTurFer
remove unused parameters
ebdaed8 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 9, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_data_explorer
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request May 13, 2023
Closed
zroubalik
zroubalik approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer merged commit 29e1429 into kedacore:main May 15, 2023
@JorTurFer JorTurFer deleted the bump-kusto branch May 15, 2023 12:24
tobotg pushed a commit to tobotg/keda that referenced this pull request May 17, 2023
@JorTurFer @tobotg
chore: Use azidentity for Azure Data Explorer (kedacore#4490)
ec1e49e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees

@zroubalik zroubalik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use azidentity SDK with Azure Data Explorer Scaler
2 participants
@JorTurFer @zroubalik