Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping up controller-runtime@v0.15.0 #4582

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Bumping up controller-runtime@v0.15.0 #4582

merged 6 commits into from
Jun 5, 2023

Conversation

prometherion
Copy link
Contributor

@prometherion prometherion commented May 29, 2023 •
edited by JorTurFer
Loading

Bumping up the kubernetes-sigs/controller-runtime dependency to v0.15.0

Checklist

Fixes #4581

@prometherion prometherion requested a review from a team as a code owner May 29, 2023 11:47
JorTurFer
JorTurFer reviewed May 29, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, could you update the changelog too?
I think that this improvement could be placed in Other section

@prometherion prometherion requested a review from JorTurFer May 29, 2023 12:19
JorTurFer
JorTurFer reviewed May 29, 2023
View reviewed changes
cmd/operator/main.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

There are some build errors, could you check them? https://github.com/kedacore/keda/actions/runs/5111676017/jobs/9188904903?pr=4582

zroubalik
zroubalik reviewed May 29, 2023
View reviewed changes
cmd/webhooks/main.go Outdated Show resolved Hide resolved
@prometherion prometherion force-pushed the issues/4581 branch 3 times, most recently from 17d55e9 to e70fd67 Compare May 30, 2023 12:40
JorTurFer
JorTurFer reviewed May 30, 2023
View reviewed changes
pkg/util/tls_config.go Outdated Show resolved Hide resolved
zroubalik
zroubalik reviewed May 31, 2023
View reviewed changes
cmd/adapter/main.go Outdated Show resolved Hide resolved
@prometherion prometherion force-pushed the issues/4581 branch 3 times, most recently from 7c536f8 to c65601e Compare May 31, 2023 08:31
@zroubalik
Copy link
Member

zroubalik commented May 31, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@prometherion
Copy link
Contributor Author

@zroubalik may I ask you for some help understanding the root cause of the failed e2e tests? 🤔

@zroubalik
Copy link
Member

@zroubalik may I ask you for some help understanding the root cause of the failed e2e tests? 🤔

seems like some unrelate env problem, let me re-trigger

@zroubalik
Copy link
Member

zroubalik commented May 31, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

looks like a consistent error, let me check it

@JorTurFer
Copy link
Member

JorTurFer commented May 31, 2023 •
edited
Loading

I can reproduce it locally:

The CustomResourceDefinition "scaledjobs.keda.sh" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

There are some missing changes in manifests too, could you run make manifests and commit the changes?

@zroubalik
Copy link
Member

I can reproduce it locally:

The CustomResourceDefinition "scaledjobs.keda.sh" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

There are some missing changes in manifests too, could you run make manifests and commit the changes?

good catch, yeah please regenerate and we can give it another try

@prometherion
Copy link
Contributor Author

good catch, yeah please regenerate and we can give it another try

Done, it would be good having a sort of automation to ensure the generated files are correctly committed.

@JorTurFer
Copy link
Member

Done, it would be good having a sort of automation to ensure the generated files are correctly committed.

You're totally right! We have already commented it internally after noticing it 😄

JorTurFer
JorTurFer reviewed Jun 1, 2023
View reviewed changes
pkg/util/tls_config.go Outdated Show resolved Hide resolved
@prometherion prometherion force-pushed the issues/4581 branch 2 times, most recently from b8a35ba to f47ea5f Compare June 1, 2023 09:04
@zroubalik
Copy link
Member

zroubalik commented Jun 1, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Jun 1, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Jun 1, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented Jun 1, 2023 •
edited by github-actions bot
Loading

/run-e2e azure
Update: You can check the progress here

@prometherion
feat(go.mod): updating sigs.k8s.io/controller-runtime@v0.15.0
5d60fc7 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion
refactor: aligning to kubernetes-sigs/controller-runtime@v0.1.50
eeab642 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion
refactor(util): parsing TLS min version as string
e146830 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion
refactor(tls): tls min version from environment variable
bf55952 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
zroubalik
zroubalik reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the typo, I'll rerun the e2e tests and we are good to go. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@prometherion
refactor(webhooks)!: removing tls-min-version flag
43c312f 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion
chore(manifests): aligning to kubernetes-sigs/controller-runtime@v0.1.50
e727d41 
Signed-off-by: Dario Tranchitella <dario@tranchitella.eu>
@prometherion prometherion requested a review from zroubalik June 5, 2023 09:27
@zroubalik
Copy link
Member

zroubalik commented Jun 5, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job, thanks!

@zroubalik zroubalik enabled auto-merge (squash) June 5, 2023 09:32
@zroubalik
Copy link
Member

zroubalik commented Jun 5, 2023 •
edited by github-actions bot
Loading

/run-e2e selenium
Update: You can check the progress here

@zroubalik zroubalik merged commit 21a6d6e into kedacore:main Jun 5, 2023
@prometherion prometherion deleted the issues/4581 branch June 5, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to sigs.k8s.io/controller-runtime@v0.15.0
3 participants
@prometherion @JorTurFer @zroubalik