Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude Azure Monitor scaler from metricName deprecation #4713

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

lsolovey
Copy link
Contributor

@lsolovey lsolovey commented Jun 21, 2023

Exclude Azure Monitor scaler from metricName deprecation.
metricName in AzureMonitor scaler refers to the actual name of the underlying metric in Azure.

Checklist

Relates to kedacore/keda-docs#1152
Relates to kedacore/keda-docs#1158

Signed-off-by: Leonid Solovey <38634160+lsolovey@users.noreply.github.com>
@lsolovey lsolovey requested a review from a team as a code owner June 21, 2023 04:19
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

@JorTurFer JorTurFer merged commit 1a23028 into kedacore:main Jun 21, 2023
@lsolovey lsolovey deleted the azure-monitor-metric-name-2 branch June 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants