Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paused ScaledObject continues after removing pause annotation #4734

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Paused ScaledObject continues after removing pause annotation #4734

merged 3 commits into from
Jun 23, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4733

@JorTurFer
fix e2e test
c78d87e 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update code and changes
f773626 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer requested a review from a team as a code owner June 23, 2023 13:23
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 23, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer changed the title Paused ScaledObject doesn't continue after removing pause annotation Paused ScaledObject continues after removing pause annotation Jun 23, 2023
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

zroubalik
zroubalik approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Much better approach! Thanks for the quick fix!

@JorTurFer
fix static error
21d4fc2 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 23, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) June 23, 2023 13:54
@JorTurFer JorTurFer mentioned this pull request Jun 23, 2023
Merged
1 task
@JorTurFer JorTurFer merged commit 04ca96e into kedacore:main Jun 23, 2023
@JorTurFer JorTurFer deleted the fix-so-pause branch June 23, 2023 14:30
@zroubalik zroubalik mentioned this pull request Jun 26, 2023
Closed
tomkerkhove pushed a commit that referenced this pull request Jun 28, 2023
@JorTurFer @tomkerkhove
Paused ScaledObject continues after removing pause annotation (#4734)
55e96a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paused ScaledObject doesn't continue after removing pause annotation
2 participants
@JorTurFer @zroubalik