Selenium Grid | Fix latest browser version use case scaling #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
Signed-off-by: Brandon Wolfe <Wolfe1@gmail.com>
Signed-off-by: Brandon Wolfe <Wolfe1@gmail.com>
Wolfe1
force-pushed
the
fix_default_scale
branch
from
aae1fab
to
6004d53
Compare
JorTurFer
reviewed
Sep 3, 2023
|
/run-e2e selenium |
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Brandon Wolfe <Wolfe1@gmail.com>
Signed-off-by: Brandon Wolfe <Wolfe1@gmail.com>
|
/skip-e2e |
JorTurFer
approved these changes
Sep 5, 2023
Adarsh-verma-14
pushed a commit
to Adarsh-verma-14/keda
that referenced
this pull request
Sep 6, 2023
…#4922) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
jeevanragula
pushed a commit
to jeevanragula/keda
that referenced
this pull request
Sep 6, 2023
…#4922) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
8 tasks
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…#4922) Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #4348 broke scaling for the default use case (using only latest browser version). Items coming into the queue do not have a version number and would get counted correctly. After those items become sessions they are assigned a version number and were no longer counted by KEDA in this scenario. After the initial scale up we would only be monitoring the queue which would lead to stalled scaling or scaling down prematurely. More details in #4858
The purposed solution is to ignore the version number on the sessions when we are using the DefaultBrowserVersion. All existing unit tests still pass and have not been modified so #4348's use case should still be in tact. Added a couple unit tests to cover this default scenario.
Checklist
When introducing a new scaler, I agree with the scaling governance policyA PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)A PR is opened to update the documentation on (repo) (if applicable)Fixes #4858
Relates to #4348