-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update CloudEventType to correct format #5277
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
/run-e2e cloudevent |
/run-e2e cloudevent |
Looking good, but you need to update the e2e test too, as it checks the event type: keda/tests/internals/cloudevent_source/cloudevent_source_test.go Lines 181 to 192 in 9c23dae
|
8506eea
to
9917a42
Compare
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
9917a42
to
5c176f3
Compare
Fixed. |
/run-e2e cloudevent |
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Update CloudEventType to correct format
Provide a description of what has been changed
Checklist
Fixes (#3533)