-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add large lag threshold test for Kafka scalers #5361
Merged
zroubalik
merged 6 commits into
kedacore:main
from
dttung2905:add-large-lag-threshold-kafka-scaler
Jan 12, 2024
Merged
chore: add large lag threshold test for Kafka scalers #5361
zroubalik
merged 6 commits into
kedacore:main
from
dttung2905:add-large-lag-threshold-kafka-scaler
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
dttung2905
force-pushed
the
add-large-lag-threshold-kafka-scaler
branch
from
January 10, 2024 22:54
224472b
to
443ce68
Compare
zroubalik
requested changes
Jan 11, 2024
btw PR Welcome Bot is failing 🤔
I think probably because of this PR #5365 . Let me try to rebase from master |
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…d test case Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
add-large-lag-threshold-kafka-scaler
branch
from
January 11, 2024 22:31
dae1ebe
to
ff2f6a5
Compare
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
zroubalik
changed the title
Add large lag threshold kafka scaler
chore: add large lag threshold test for Kafka scalers
Jan 12, 2024
zroubalik
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
sguruvar
pushed a commit
to sguruvar/keda
that referenced
this pull request
Jan 15, 2024
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
I'm adding a new test case from my investigation here.
Checklist
Relates to #5354