-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make improvement to getParameterFromConfigV2
#5391
Make improvement to getParameterFromConfigV2
#5391
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking promising, I wouldn't necessarily make every argument to getParameterFromConfigV2
an option because some are actually required, otherwise the invocation of the function doesn't make much sense.
overall pretty good!
ca6b29a
to
4f7495c
Compare
cb1ed61
to
49571cc
Compare
e4b884f
to
4f0c4af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, I like the direction.
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
f24d974
to
08c472c
Compare
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg> Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com>
From the slack discussion, we should make some improvements to the
getParameterFromConfigV2
util function to make it more readable.I create a new PR instead of adding on to #5319 as I want to make this change modular, just showcasing the alternative without refactoring hundreds of lines on the other PR.
How we use the function would be something like
Checklist