Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider empty results set from new relic #5621

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: consider empty results set from new relic #5621

merged 4 commits into from
Mar 26, 2024

Conversation

cyrilico
Copy link
Contributor

@cyrilico cyrilico commented Mar 25, 2024

Handle empty results set returned by New Relic query executor.

Checklist

Fixes #5619

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>
Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>
@cyrilico cyrilico requested a review from a team as a code owner March 25, 2024 11:06
Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Mar 25, 2024

/run-e2e new_relic
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) March 25, 2024 22:37
@cyrilico
Copy link
Contributor Author

@JorTurFer something seemed to go wrong with provisioning for the tests, can you run them again?

@JorTurFer
Copy link
Member

Could you resolve the changelog conflicts please?

@JorTurFer
Copy link
Member

JorTurFer commented Mar 26, 2024

/run-e2e newrelic
Update: You can check the progress here

@tomkerkhove
Copy link
Member

@cyrilico Mind fixing the conflict please?

Signed-off-by: damas <19289022+cyrilico@users.noreply.github.com>
auto-merge was automatically disabled March 26, 2024 10:07

Head branch was pushed to by a user without write access

@cyrilico
Copy link
Contributor Author

@tomkerkhove @JorTurFer fixed 🙏

@JorTurFer
Copy link
Member

JorTurFer commented Mar 26, 2024

/run-e2e newrelic
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) March 26, 2024 18:17
@JorTurFer JorTurFer merged commit 6bc6139 into kedacore:main Mar 26, 2024
19 checks passed
@cyrilico cyrilico deleted the fix_new_relic_scaler_query_error_handling branch March 26, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Relic Scaler causes panic when query returns no results
3 participants