Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prometheus metrics expose correct info #5779

Merged
merged 3 commits into from
May 6, 2024
Merged

fix: Prometheus metrics expose correct info #5779

merged 3 commits into from
May 6, 2024

Conversation

JorTurFer
Copy link
Member

I have modified the wrong comment on Prometheus metric and I've added e2e test for those new metrics too

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@JorTurFer
fix: Prometheus metrics expose correct info
a7db3a1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner May 3, 2024 20:24
@JorTurFer
Copy link
Member Author

JorTurFer commented May 3, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
fix e2e
bad4231 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 3, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@JorTurFer
fix prometheus metric
2e507a3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 6, 2024 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

zroubalik
zroubalik approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zroubalik zroubalik merged commit c7e901f into kedacore:main May 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @zroubalik @tomkerkhove