Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Artemis scaler config #5836

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dttung2905
Copy link
Contributor

Refactor artemis scaler config reading with a better way

Checklist

Relates to #5797

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 requested a review from a team as a code owner May 29, 2024 22:27
@dttung2905
Copy link
Contributor Author

dttung2905 commented May 30, 2024

/run-e2e artemis
Update: You can check the progress here

@dttung2905
Copy link
Contributor Author

@kedacore/keda-contributors @wozniakjan please help to take a look at this 🙏

Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, very well done :)

@zroubalik zroubalik enabled auto-merge (squash) June 4, 2024 09:37
@zroubalik zroubalik disabled auto-merge June 4, 2024 09:37
@zroubalik zroubalik enabled auto-merge (squash) June 4, 2024 09:37
@zroubalik zroubalik merged commit e25aca9 into kedacore:main Jun 4, 2024
22 checks passed
rxg8255 pushed a commit to rxg8255/keda that referenced this pull request Jun 24, 2024
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
uucloud pushed a commit to uucloud/keda that referenced this pull request Jul 11, 2024
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: uucloud <uucloud@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants