Refactor IBM MQ scaler and remove and deprecate variables #6034
+100
−178
Task list completed / task-list-completed
succeeded
Aug 20, 2024 in 0s
5 / 5 tasks completed
All tasks have been completed
Details
Required Tasks
Task | Status |
---|---|
The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed. |
Incomplete |
The parameter tlsDisabled (as mentioned in the documentation) / tls (as mentioned in the code) will be announced as being deprecated in a further release. All other scalers use the parameter unsafeSsl . To maintain consistency between other scalers, we are making changes, as unsafeSsl already handles this functionality. tls will still be supported. When both variables are filled in, an error message is logged and returned. If only tls is filled in, its value will be assigned to unsafeSsl . A deprecation info message will be logged. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead in version 2.18 and remove the deprecated code. |
Incomplete |
Refactor the scaler to match the new metadata guidelines. | Incomplete |
I have verified that my change is according to the deprecations & breaking changes policy | Completed |
Tests have been added | Completed |
Changelog has been updated and is aligned with our changelog requirements | Completed |
A PR is opened to update the documentation on (repo) (if applicable) | Completed |
Commits are signed with Developer Certificate of Origin (DCO - learn more) | Completed |
Loading