kafka: allow disabling kerberos FAST in sarama client #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jkyros
force-pushed
the
allow-disable-krb-fast
branch
from
3f28c8f
to
8a27419
Compare
|
/run-e2e kafka |
JorTurFer
approved these changes
Oct 6, 2024
dttung2905
reviewed
Oct 7, 2024
There was a problem hiding this comment.
LGTM. I think we have a CI error (here)
=== FAIL: pkg/scalers TestParseElasticsearchMetadata/no_index_given (0.00s)
elasticsearch_scaler_test.go:321:
Error Trace: /__w/keda/keda/pkg/scalers/elasticsearch_scaler_test.go:321
Error: "missing required parameter [\"index\"] in [authParams triggerMetadata]\nmissing required parameter [\"searchTemplateName\"] in [authParams triggerMetadata]\nmissing required parameter [\"valueLocation\"] in [authParams triggerMetadata]\nmissing required parameter [\"targetValue\"] in [authParams triggerMetadata]\nboth username and password must be provided when addresses is used" does not contain "missing required parameter \"index\""
Test: TestParseElasticsearchMetadata/no_index_given
I don't think its related to our changes. @JorTurFer Could you help to confirm this too?
Our sarama client has kerberos FAST negotiation turned on by default, but there are KDCs that can't handle FAST negotiation and will fail. There is an option to configure this on the sarama client, but we didn't expose it anywhere, so users couldn't get to it. This just adds an additional auth parameter to AuthConfig to expose that configuration option so users who need to shut off FAST are able to do so. Signed-off-by: John Kyros <jkyros@redhat.com>
jkyros
force-pushed
the
allow-disable-krb-fast
branch
from
8a27419
to
18264ad
Compare
|
rebased and resolved CHANGELOG conflict 😄 |
|
/run-e2e kafka |
|
PTAL @kedacore/keda-core-contributors |
zroubalik
approved these changes
Oct 18, 2024
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
Our sarama client has kerberos FAST negotiation turned on by default, but there are KDCs that can't handle FAST negotiation and will fail. There is an option to configure this on the sarama client, but we didn't expose it anywhere, so users couldn't get to it. This just adds an additional auth parameter to AuthConfig to expose that configuration option so users who need to shut off FAST are able to do so. Signed-off-by: John Kyros <jkyros@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
kerberosDisableFASTfield to the kafka scaler metadata, which can be used to disable sarama's/gokrb5's FAST negotiation for kerberos connectionskerberosDisableFASTfield in the AuthConfigWhich will let a user disable FAST as part of their Kerberos configuration.
I'm not attached to any of the naming here, I just want the plumbing, right now we just can't manipulate this at all. 😄
Checklist
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)Fixes #6188