Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent multiple ScaledObjects managing one HPA #6198

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Prevent multiple ScaledObjects managing one HPA #6198

merged 3 commits into from
Oct 22, 2024

Conversation

dovics
Copy link
Contributor

@dovics dovics commented Sep 29, 2024 •
edited by wozniakjan
Loading

Provide a description of what has been changed

Prevent multiple ScaledObjects managing one HPA

Checklist

Fixes #6130

Relates to #

@dovics dovics requested a review from a team as a code owner September 29, 2024 11:33
JorTurFer
JorTurFer reviewed Sep 29, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just a note about the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Sep 29, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@dovics
Copy link
Contributor Author

dovics commented Sep 30, 2024 •
edited
Loading

Sorry, I missed a line of code when commit, which caused the e2e test in scaled_object_validation_test.go to fail.

I've rebased main, to solve the other two failed.

@dovics
Prevent multiple ScaledObjects managing one HPA
8ef04df 
Signed-off-by: wangrushen <wrs369@88.com>
@dovics
fix: e2e test and mv changelog to improvements
de0f603 
Signed-off-by: wangrushen <wrs369@88.com>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal

Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Oct 2, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer
Copy link
Member

PTAL @zroubalik @wozniakjan

@dovics
check nil for spec.advanced.horizontalPodAutoscalerConfig
4a7cb03 
Signed-off-by: wangrushen <wrs369@88.com>
@wozniakjan
Copy link
Member

wozniakjan commented Oct 22, 2024 •
edited by github-actions bot
Loading

/run-e2e internals
Update: You can check the progress here

@wozniakjan wozniakjan enabled auto-merge (squash) October 22, 2024 10:50
@wozniakjan wozniakjan merged commit d849c75 into kedacore:main Oct 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dovics @JorTurFer @wozniakjan