Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Cassandra scaler #6275

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Refactor Cassandra scaler #6275

merged 2 commits into from
Nov 3, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 27, 2024 •
edited
Loading

  • Refactor the scaler to match the new metadata guidelines.

Checklist

Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 27, 2024 13:42
@rickbrouwer rickbrouwer marked this pull request as draft October 27, 2024 13:53
@rickbrouwer
Refactor cassandra scaler
a38df8c 
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@rickbrouwer rickbrouwer marked this pull request as ready for review October 27, 2024 15:56
@wozniakjan
Copy link
Member

wozniakjan commented Oct 28, 2024 •
edited by github-actions bot
Loading

/run-e2e cassandra
Update: You can check the progress here

@wozniakjan wozniakjan mentioned this pull request Oct 28, 2024
Open
59 tasks
@rickbrouwer
Update feedback
e8996a8 
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@wozniakjan
Copy link
Member

wozniakjan commented Oct 29, 2024 •
edited by github-actions bot
Loading

/run-e2e cassandra
Update: You can check the progress here

wozniakjan
wozniakjan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@JorTurFer JorTurFer merged commit b34fad0 into kedacore:main Nov 3, 2024
22 checks passed
@rickbrouwer rickbrouwer deleted the cassandra branch November 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpiritZhou SpiritZhou SpiritZhou left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickbrouwer @wozniakjan @SpiritZhou @JorTurFer