Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return if kafka offset response is nil #689

Merged
merged 1 commit into from
Mar 17, 2020
Merged

return if kafka offset response is nil #689

merged 1 commit into from
Mar 17, 2020

Conversation

flecno
Copy link
Contributor

@flecno flecno commented Mar 17, 2020

Fixes #688

@flecno
return if kafka offset response is nil
9bb9825 
Signed-off-by: Timo Zingel <timo.zingel@joblift.de>
ahmelsayed
ahmelsayed approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @flecno for the fix!!

@tomkerkhove tomkerkhove merged commit 3692eca into kedacore:master Mar 17, 2020
@flecno flecno deleted the kafka-nil-pointer branch April 23, 2020 20:24
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@chalin
Fix some broken anchors (kedacore#689)
bbb5a1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed ahmelsayed approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keda-operator crashs with SIGSEGV for kafka scaler
3 participants
@flecno @ahmelsayed @tomkerkhove