Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter returned metrics from api server based on queried name. Issue # 702 #732

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

ycabrer
Copy link
Contributor

@ycabrer ycabrer commented Apr 8, 2020

Signed-off-by: ycabrer 43866176+ycabrer@users.noreply.github.com

Filter Metrics case insensitive based on metric name.

Checklist

Fixes #702

Signed-off-by: ycabrer <43866176+ycabrer@users.noreply.github.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work on that!

@zroubalik zroubalik merged commit 5d487de into kedacore:master Apr 8, 2020
zroubalik pushed a commit that referenced this pull request Apr 8, 2020
Signed-off-by: ycabrer <43866176+ycabrer@users.noreply.github.com>
AmithGanesh pushed a commit to AmithGanesh/keda that referenced this pull request May 18, 2020
…re#732)

Signed-off-by: ycabrer <43866176+ycabrer@users.noreply.github.com>
Signed-off-by: Amith Ganesh <amith.ganesh1284@gmail.com>
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Prometheus Scalers in same scaled object return same metric values
2 participants