Skip to content

Commit

Permalink
Disable a few more faulty pylint checks
Browse files Browse the repository at this point in the history
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
  • Loading branch information
astrojuanlu committed Jul 20, 2023
1 parent 3f0b644 commit 5168a47
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion kedro-datasets/kedro_datasets/pandas/gbq_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,5 +317,5 @@ def _load(self) -> pd.DataFrame:
**load_args,
)

def _save(self, data: None) -> NoReturn:
def _save(self, data: None) -> NoReturn: # pylint: disable=no-self-use
raise DataSetError("'save' is not supported on GBQQueryDataSet")
2 changes: 1 addition & 1 deletion kedro-datasets/kedro_datasets/pandas/sql_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ def _load(self) -> pd.DataFrame:

return pd.read_sql_query(con=engine, **load_args)

def _save(self, data: None) -> NoReturn:
def _save(self, data: None) -> NoReturn: # pylint: disable=no-self-use
raise DataSetError("'save' is not supported on SQLQueryDataSet")

# For mssql only
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def test_full_table(self):
assert unity_ds._table.full_table_location() == "`default`.`test`"

with pytest.raises(TypeError):
ManagedTableDataSet()
ManagedTableDataSet() # pylint: disable=no-value-for-parameter

def test_describe(self):
unity_ds = ManagedTableDataSet(table="test")
Expand Down

0 comments on commit 5168a47

Please sign in to comment.