Skip to content

Commit

Permalink
feat(datasets): add deprecation warning for tracking datatsets (#955)
Browse files Browse the repository at this point in the history
* add deprecation warning for tracking datatsets

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

* update release note

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>

* Update kedro-datasets/RELEASE.md

Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>

* Fix linting

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>

---------

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Co-authored-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Merel Theisen <merel.theisen@quantumblack.com>
  • Loading branch information
4 people authored Dec 2, 2024
1 parent 1e33d07 commit f7a65c5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions kedro-datasets/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
## Bug fixes and other changes
- Implemented Snowflake's (local testing framework)[https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally] for testing purposes
- Improved the dependency management for Spark-based datasets by refactoring the Spark and Databricks utility functions used across the datasets.
- Add deprecation warning for `tracking.MetricsDataset` and `tracking.JSONDataset`.

## Breaking Changes
- Demoted `video.VideoDataset` from core to experimental dataset.
Expand Down
9 changes: 9 additions & 0 deletions kedro-datasets/kedro_datasets/tracking/__init__.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
"""Dataset implementations to save data for Kedro Experiment Tracking."""

import warnings
from typing import Any

import lazy_loader as lazy

from kedro_datasets import KedroDeprecationWarning

# https://github.com/pylint-dev/pylint/issues/4300#issuecomment-1043601901
JSONDataset: Any
MetricsDataset: Any
Expand All @@ -15,3 +18,9 @@
"metrics_dataset": ["MetricsDataset"],
},
)

warnings.warn(
"`tracking.JSONDataset` and `tracking.MetricsDataset` are deprecated. These datasets will be removed in kedro-datasets 7.0.0",
KedroDeprecationWarning,
stacklevel=2,
)

0 comments on commit f7a65c5

Please sign in to comment.