-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the kedro_init_version
to ProjectMetadata
#119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
deepyaman-patch-2
branch
from
February 20, 2023 01:10
e77af5b
to
158eddf
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
noklam
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thanks for fixing this.
SajidAlamQB
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🌟
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar
pushed a commit
to dannyrfar/kedro-plugins
that referenced
this pull request
Mar 21, 2023
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix broken tests resulting from kedro-org/kedro#2219
Development notes
Triggered tests for all plugins (except datasets, but manually checked that tests don't require metadata there). Standardized docstrings along the way. 🤷
Checklist
RELEASE.md
file