Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the kedro_init_version to ProjectMetadata #119

Merged
merged 6 commits into from
Feb 20, 2023
Merged

Pass the kedro_init_version to ProjectMetadata #119

merged 6 commits into from
Feb 20, 2023

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Feb 17, 2023 •
edited
Loading

Description

Fix broken tests resulting from kedro-org/kedro#2219

Development notes

Triggered tests for all plugins (except datasets, but manually checked that tests don't require metadata there). Standardized docstrings along the way. 🤷

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@deepyaman
Pass the kedro_init_version to ProjectMetadata
01def94 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Trigger Airflow tests
726c1ff 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman marked this pull request as ready for review February 20, 2023 05:23
@deepyaman deepyaman self-assigned this Feb 20, 2023
noklam
noklam approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for fixing this.

SajidAlamQB
SajidAlamQB approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🌟

@merelcht merelcht merged commit 8a9d376 into main Feb 20, 2023
@merelcht merelcht deleted the deepyaman-patch-2 branch February 20, 2023 10:08
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 13, 2023
@deepyaman @dannyrfar
Pass the kedro_init_version to ProjectMetadata (kedro-org#119)
d6ab04f 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Pass the kedro_init_version to ProjectMetadata (kedro-org#119)
59a58ae 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Pass the kedro_init_version to ProjectMetadata (kedro-org#119)
e17e8d1 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
dannyrfar pushed a commit to dannyrfar/kedro-plugins that referenced this pull request Mar 21, 2023
@deepyaman @dannyrfar
Pass the kedro_init_version to ProjectMetadata (kedro-org#119)
5de5fd9 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Danny Farah <danny_farah@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@merelcht merelcht Awaiting requested review from merelcht

Assignees

@deepyaman deepyaman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepyaman @noklam @SajidAlamQB @merelcht