Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] chore(datasets): Update setup.py for snowpark #238

Closed
wants to merge 5 commits into from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jun 14, 2023

Description

The current pin for snowflake-snowpark-python is 1.0.0, which only support Python 3.8, the latest version support Python 3.8 & 3.9 instead.

https://pypi.org/project/snowflake-snowpark-python/#history

Development notes

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@noklam
Copy link
Contributor Author

noklam commented Jun 14, 2023

Pinging @heber-urdaneta @mobilize-mrojas @orellabac @Vladimir-Filimonov as I found you are the original author of this PR

@noklam noklam changed the title Update setup.py for snowpark chore(datasets): Update setup.py for snowpark Jun 14, 2023
@noklam noklam marked this pull request as draft June 15, 2023 10:59
@noklam noklam changed the title chore(datasets): Update setup.py for snowpark [DON'T MERGE] chore(datasets): Update setup.py for snowpark Jun 15, 2023
@Vladimir-Filimonov
Copy link
Contributor

Vladimir-Filimonov commented Jun 21, 2023

Hey all. I tried running snowflake unit tests using this PR and virtual environment of python 3.9 - no luck, requirements installation fails. If I try to repeat CI steps from here https://github.com/kedro-org/kedro-plugins/blob/main/.github/workflows/check-plugin.yml#L40
installation of requirements fails:

I'm on vacation now and don't have much time to experiment myself, but if you can make requirements installation work I'm happy to run Snowflake unit tests to confirm everything is alright early next week.

Other suggestion:

@astrojuanlu astrojuanlu self-requested a review June 21, 2023 11:53
@noklam
Copy link
Contributor Author

noklam commented Jun 22, 2023

We are working on adding python 3.11 support and it's likely we will bump many of the dependency to support Spark better. Thanks for looking into it @Vladimir-Filimonov

@astrojuanlu
Copy link
Member

Now that #297 is merged, maybe this is worth revisiting?

@noklam
Copy link
Contributor Author

noklam commented Sep 25, 2023

I checked again, they now support >=3.8 <3.11 https://pypi.org/project/snowflake-snowpark-python/#history. Just update the requirements and see if CI can install these properly.

noklam and others added 2 commits September 25, 2023 17:54
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu
Copy link
Member

This was done in #442

@astrojuanlu astrojuanlu deleted the fix-snowpark branch November 30, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants