ci(airflow): Pin apache-airflow version #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
|
They also dropped support for Python 3.7 btw 👀 |
astrojuanlu
reviewed
Aug 23, 2023
kedro-airflow/pyproject.toml
Outdated
| @@ -24,7 +24,7 @@ Tracker = "https://github.com/kedro-org/kedro-plugins/issues" | |||
|
|
|||
| [project.optional-dependencies] | |||
| test = [ | |||
| "apache-airflow<3.0", | |||
| "apache-airflow<2.7.0", | |||
There was a problem hiding this comment.
+1 but can we add a comment with an explanation? so we remember when we get to fix it
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
astrojuanlu
approved these changes
Aug 23, 2023
|
Thanks @ankatiyar ! |
noklam
approved these changes
Aug 23, 2023
PtrBld
pushed a commit
to PtrBld/kedro-plugins
that referenced
this pull request
Aug 27, 2023
* Pin airflow version Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add comment Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #295 failing end to end tests for
kedro-airflowDevelopment notes
There was a new release for
apache-airflowon 18th August 2023 which broke something withsqlalchemyWhat do we think about setting version for
apache-airflowto<2.7.0for now?Checklist
RELEASE.mdfile