Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): add integration tests #771

Merged
merged 15 commits into from
Sep 24, 2024

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Jul 19, 2024

Description

Integration tests for the Kedro telemetry plugin ensure that only one event is sent to Heap Analytics per Kedro command. To facilitate this, a dummy project was created, and the tests verify the behaviour of the run and info CLI commands, as well as a session run without using the CLI.

Originally made by @noklam , was separated from #766, closes #770

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
DimedS and others added 8 commits September 5, 2024 16:00
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
@DimedS DimedS marked this pull request as ready for review September 12, 2024 15:20
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
@DimedS DimedS requested a review from noklam September 19, 2024 15:59
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DimedS! LGTM ✨

@DimedS DimedS merged commit 4b75db7 into main Sep 24, 2024
10 checks passed
@DimedS DimedS deleted the 770-kedro-telemetry-add-integration-tests branch September 24, 2024 08:52
harm-matthias-harms pushed a commit to harm-matthias-harms/kedro-plugins that referenced this pull request Oct 1, 2024
Add integration tests for telemetry ensure that only one event is sent to Heap Analytics per Kedro command
---------

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Co-authored-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Harm Matthias Harms <matthias.harms@quis.de>
MinuraPunchihewa pushed a commit to MinuraPunchihewa/kedro-plugins that referenced this pull request Oct 1, 2024
Add integration tests for telemetry ensure that only one event is sent to Heap Analytics per Kedro command
---------

Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com>
Co-authored-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Minura Punchihewa <minurapunchihewa17@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-telemetry: Add Integration tests to ensure telemetry event sends only once per command
4 participants