Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakdown flowchart models into separate files #1909

Open
1 task done
ravi-kumar-pilla opened this issue May 15, 2024 · 1 comment
Open
1 task done

Breakdown flowchart models into separate files #1909

ravi-kumar-pilla opened this issue May 15, 2024 · 1 comment
Assignees
@SajidAlamQB
Labels
Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do

Comments

@ravi-kumar-pilla
Copy link
Contributor

Description

The flowchart model file has 1066 lines of code and this needs to be breakdown for easy maintenance and readability

Context

As above

Possible Implementation

Create separate files each for a class within flowchart folder under models.

models
  flowchart
    graph_edge.py
    graph_node.py

Checklist

  • Include labels so that we can categorise your feature request
@ravi-kumar-pilla ravi-kumar-pilla added Enhancement Issue: Feature Request Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do labels May 15, 2024
@rashidakanchwala
Copy link
Contributor

Great idea, should we break it into edges, nodes, and metadata?

@SajidAlamQB SajidAlamQB mentioned this issue Oct 17, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SajidAlamQB SajidAlamQB

Labels
Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do
Projects
Kedro-Viz
Status: In Review
Milestone
No milestone
Development

No branches or pull requests
4 participants
@astrojuanlu @rashidakanchwala @ravi-kumar-pilla @SajidAlamQB