Breakdown flowchart models into separate files #2144
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
| return info.data["id"] | ||
|
|
||
|
|
||
| class RegisteredPipeline(NamedEntity): |
There was a problem hiding this comment.
Hi @SajidAlamQB , most of the splitting looks good. Some suggestions -
On first look, entities file is not obvious on what it contains but the class names make sense here. I would have the below structure -
- flowchart
- nodes
- node_metadata
- edge
- pipelines
- tag
- model_utils
- NamedEntity can be in entity or model_utils
- RegisteredPipeline can be in pipelines and Tag in its own tag file.
- Model file names are singular if we are not having multiple classes (nodes and pipelines can be plural as they have collection of classes)
Thank you
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #1909
Development notes
Added the following:
QA notes
Checklist
RELEASE.mdfile