-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove session store #2219
Feature/remove session store #2219
Conversation
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
# SESSION_STORE_ARGS = {"path": str(Path(__file__).parents[2] / "data"), | ||
# "remote_path": "s3://{path-to-session_store}" } | ||
|
||
# Define custom context class. Defaults to `KedroContext` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can keep the code from line 18-23 as is, as this is not related to ET
@@ -21,21 +21,3 @@ def configure_wal_for_azure(engine): | |||
if is_azure_ml: | |||
with engine.connect() as conn: | |||
conn.execute(text("PRAGMA journal_mode=WAL;")) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is for handling SQLite which is not needed anymore, so I guess we can delete the file entirely
CONTRIBUTING.md
Outdated
```python | ||
from kedro_viz.integrations.kedro.sqlite_store import SQLiteStore | ||
SESSION_STORE_ARGS = {"path": str(Path(__file__).parents[2] / "data")} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make changes to all the starter templates (may be a note saying kedro-viz v11 does not support ET) as a follow up - https://github.com/kedro-org/kedro-starters/blob/main/spaceflights-pandas-viz/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/%7B%7B%20cookiecutter.python_package%20%7D%7D/settings.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, @merelcht has already raised this concern, and I’ll create a ticket for it. For now, we’ve added a deprecation warning for Kedro datasets to alert users about this change coming in the next release.
Hi @Huongg , I know this PR is related to removing only Session store. I had a brief look and it looks fine for me. In general, I prepared a checklist as reference (you may add to this, but overall this would suffice) -
I hope this helps. I will also have a look at this PR once it is ready for review. Thank you |
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Thanks, @ravi-kumar-pilla, for the helpful guidance! I’ve implemented your suggestion to update the code related to removing session_store. The changes related to GraphQL and the router will be addressed in a separate PR to keep this one more focused and easier to review. Please take a look and let me know your thoughts. Currently, the test coverage isn’t at 100% because I’ve deleted all the graphql_tests. Since the GraphQL-related code will be removed soon, I’m wondering if it's okay to ignore this in the PR for now. Here's the link to the error for reference: https://github.com/kedro-org/kedro-viz/actions/runs/12160128272/job/33911739972?pr=2219 |
Is the plan to remove all of the graphql code, or only that which relates to experiment tracking? I'm in favor of removing it entirely. There's one graphql request that's used on the flowchart page though, and that's the |
hey so I'm thinking we're removing the graphql code related to ET in this PR, and I've opened a new issue separately to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Huongg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Huongg, I've looked through most of the changes and it LGTM!
…/remove-session-store Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
7ca0bd0
into
feature_branch/remove-experiment-tracking
Description
Fixes #2208
This PR is part of the effort to remove experiment tracking by removing the session store from the back-end.
Main Changes:
QA Notes:
Please pull the changes locally and check that the app runs without errors,
Checklist
RELEASE.md
file