-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove-grahpql #2222
Feature/remove-grahpql #2222
Conversation
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
…/remove-graphql-et
…/remove-graphql-et Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we still need the graphql directory, I see most things are removed except a few functions?
Hey it's because we still need graphQl to query the version of kedro viz, there is a separate ticket to remove that entirely so there's no more graphql #2221 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Huongg!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in terms of code changes. Thanks @Huongg
4e45f35
into
feature_branch/remove-experiment-tracking
Description
Fixes #2208
This PR is part of the effort to remove experiment tracking by removing the all the graphql from the back-end, apart from the one to get the kedro_viz version
Main Changes:
QA notes:
Currently, it fails to run locally due to the removal of some Apollo queries. I’m hoping these issues will be resolved once the Front-end PR is merged. In the meantime, please review primarily on the code changes.
Checklist
RELEASE.md
file