Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove-grahpql #2222

Merged

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Dec 5, 2024

Description

Fixes #2208
This PR is part of the effort to remove experiment tracking by removing the all the graphql from the back-end, apart from the one to get the kedro_viz version

Main Changes:

  • Remove graphql folder from api
  • Remove graphql_router from apps.py
  • Remove /experiment-tracking from apps.py

QA notes:

Currently, it fails to run locally due to the removal of some Apollo queries. I’m hoping these issues will be resolved once the Front-end PR is merged. In the meantime, please review primarily on the code changes.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg mentioned this pull request Dec 5, 2024
8 tasks
@Huongg Huongg requested review from merelcht, SajidAlamQB and jitu5 and removed request for rashidakanchwala December 5, 2024 11:57
Huong Nguyen added 2 commits December 5, 2024 12:23
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg changed the base branch from main to feature_branch/remove-experiment-tracking December 6, 2024 10:46
Huong Nguyen added 7 commits December 9, 2024 10:17
…/remove-graphql-et

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we still need the graphql directory, I see most things are removed except a few functions?

@Huongg
Copy link
Contributor Author

Huongg commented Dec 9, 2024

Why do we still need the graphql directory, I see most things are removed except a few functions?

Hey it's because we still need graphQl to query the version of kedro viz, there is a separate ticket to remove that entirely so there's no more graphql #2221

Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Huongg!

Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in terms of code changes. Thanks @Huongg

@Huongg Huongg merged commit 4e45f35 into feature_branch/remove-experiment-tracking Dec 10, 2024
53 checks passed
@Huongg Huongg deleted the feature/remove-graphql-et branch December 10, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ET back-end components
3 participants