Skip to content

Commit

Permalink
Merge branch 'main' into refactor_test_pipeline
Browse files Browse the repository at this point in the history
Signed-off-by: Adam Kells <adam.kells@artefact.com>
  • Loading branch information
adamkells authored Oct 30, 2023
2 parents fd6c4cb + df9f174 commit 19db6b6
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 14 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/all-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,40 +25,40 @@ jobs:
unit-tests:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/unit-tests.yml
with:
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
branch: ${{ inputs.branch }}

lint:
e2e-tests:
strategy:
matrix:
os: [ ubuntu-latest ]
python-version: [ "3.11" ]
uses: ./.github/workflows/lint.yml
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/e2e-tests.yml
with:
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
branch: ${{ inputs.branch }}

e2e-tests:
lint:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/e2e-tests.yml
os: [ ubuntu-latest ]
python-version: [ "3.11" ]
uses: ./.github/workflows/lint.yml
with:
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
branch: ${{ inputs.branch }}


pip-compile:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
os: [ windows-latest, ubuntu-latest ]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
uses: ./.github/workflows/pip-compile.yml
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ jobs:
- name: pip freeze
run: pip freeze
- name: Run unit tests
if: inputs.os == 'ubuntu-latest'
if: inputs.os == 'ubuntu-latest' || inputs.branch == 'develop'
run: make test
- name: Run unit tests without spark (Windows)
if: inputs.os == 'windows-latest'
if: inputs.os == 'windows-latest' && inputs.branch != 'develop'
run: make test-no-spark
3 changes: 2 additions & 1 deletion docs/source/development/set_up_vscode.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ PYTHONPATH=C:/path/to/project/src;%PYTHONPATH%

You can find [more information about setting up environmental variables in the VSCode documentation](https://code.visualstudio.com/docs/python/environments#_environment-variable-definitions-file).

Go to **Debug > Add Configurations**.
Click on the **Run and Debug** icon on the left activity bar (press `Cmd + Shift + D` for macOS). If there is no existing configuration, click on **create a launch.json file** else click on the dropdown arrow in the top-left (shown below) and click **Add Configuration** .
![](../meta/images/vscode_add_configuration.png)

```{note}
If you encounter the following error: `Cannot read property 'openConfigFile' of undefined`, you can manually create `launch.json` file in `.vscode` directory and paste the configuration from below.
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 19db6b6

Please sign in to comment.