Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divorce config loader from logging.yml #2426

Closed
1 of 5 tasks
Tracked by #2205
antonymilne opened this issue Mar 16, 2023 · 2 comments · Fixed by #2642
Closed
1 of 5 tasks
Tracked by #2205

Divorce config loader from logging.yml #2426

antonymilne opened this issue Mar 16, 2023 · 2 comments · Fixed by #2642
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Mar 16, 2023

Note. Breaking, goes in 0.19.0.

Following #2281 we have decided that users will no longer be able to change logging configuration dependent on kedro run environment. This is a huge simplification and means that logging only gets configured once in the kedro process with LOGGING = _ProjectLogging().

There's a few things to be done here, but they all need to be done at the same time or it will be very confusing.

  • Remove KedroSession._setup_logging and KedroSession._get_logging_config 🥳
  • Remove everything to do with logging from all config loaders (e.g. in config_patterns and docstring examples)
  • Double check you've removed everything that needs removing by searching logging throughout the whole codebase. Note that configure_logging must stay since it's needed by the parallel runner
  • Update all starters to move conf/base/logging.yml to conf/logging.yml #2644
  • Make sure you explain in the release notes migration guide that a custom logging file is now independent of kedro run environment and only used if KEDRO_LOGGING_CONFIG is set to point to it
@datajoely
Copy link
Contributor

fantastic use of the verb

@noklam
Copy link
Contributor

noklam commented Jun 12, 2023

Closed by #2642

@noklam noklam closed this as completed Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants