Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple logging.yml from ConfigLoader #2637

Closed
wants to merge 34 commits into from
Closed

Decouple logging.yml from ConfigLoader #2637

wants to merge 34 commits into from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jun 5, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Fix #2426

Note. Breaking, goes in 0.19.0.

Following #2281 we have decided that users will no longer be able to change logging configuration dependent on kedro run environment. This is a huge simplification and means that logging only gets configured once in the kedro process with LOGGING = _ProjectLogging().

There's a few things to be done here, but they all need to be done at the same time or it will be very confusing.

  • Remove KedroSession._setup_logging and KedroSession._get_logging_config 🥳
  • Remove everything to do with logging from all config loaders (e.g. in config_patterns and docstring examples)
  • Double check you've removed everything that needs removing by searching logging throughout the whole codebase. Note that configure_logging must stay since it's needed by the parallel runner
  • Update all starters and default project template to remove conf/base/logging.yml
  • Make sure you explain in the release notes migration guide that a custom logging file is now independent of kedro run environment and only used if KEDRO_LOGGING_CONFIG is set to point to it
  • Update docs to reflect all the above. This could be done as part of a separate ticket and should include an example logging.yml file that a user could download and put in their conf directory if they wanted to, e.g. to add file-based logging. Note that after this change, file-based logging becomes opt-in rather than opt-out as it is currently. Docs should reflect this.
  • [ ]

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

noklam and others added 30 commits February 10, 2023 12:51
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
4565684 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
67cff2d 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
055124e 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
842e83c 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
dcf3942 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@stichbury
Remove unnecessary files and subheaders in documentation (#2563)
6531457 
Tidying up.
@merelcht @jmholzer
Leverage PEP-585 (#2540)
6239e78 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Co-authored-by: Jannic <37243923+jmholzer@users.noreply.github.com>
@stichbury
[READY] Bring deployment docs up-to-date and add new pages for additi…
37b1d17 
…onal targets (#2557)

Ready at last. Still some conversation to be had about how we reflect "confidence" in the plugins we describe (what version they were last tested against) but the text is ready and better than what's there currently, so let's go!
@astrojuanlu
Remove mentions to .egg and stop producing them from kedro package (
891771d 
#2568)

* Stop producing `.egg` files from `kedro package`

Fix gh-2273.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Upgrade import-linter

Fix gh-2570.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Partially remove reliance on setup.py for micropackaging

Incomplete effort, see gh-2414.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Revert "Partially remove reliance on setup.py for micropackaging"

This reverts commit fd3efa8.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@noklam @antonymilne
OmegaConfigLoader returns Dict instead of DictConfig, resolves ru…
0b5fc97 
…ntime_params properly (#2467)

* Fix typehint

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* test push

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* POC of fix to solve the runtime param resolution problem

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix OmegaConfigLoadaer - resolve runtime_params early

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Delegate the intialization of runtime_params to AbstractConfigLoader

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Add test for interpolated value and globals

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* add more test and linting

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* refactor

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* update release note

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Apply comments and refactor the test

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Update RELEASE.md

Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>

---------

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
f6cd61e 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Revert special logic handling DictConfig (#2582)
6df4d40 
* Partially revert #2378 as OCL no longer returning DictConfig

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Revert #2176 with special logging handling

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* remove unused import

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@stichbury @jmholzer
Re-title and modify introduction to databricks testing guide in contr…
3ea7231 
…ibution section (#2579)

* modify databricks testing guide for contributors

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/contribution/development_for_databricks.md

Co-authored-by: Jannic <37243923+jmholzer@users.noreply.github.com>

* Update development_for_databricks.md

---------

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jannic <37243923+jmholzer@users.noreply.github.com>
@noklam
Quick fix .gitpod.yml (#2585)
16d8a75
@ankatiyar
OmegaConfigLoader should not show MissingConfigException when the…
3439e72 
… file is empty (#2584)

* Allow empty config files

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Remove condition for empty config

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Revert "Remove condition for empty config"

This reverts commit 7961155.

* Update release notes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

* Add unit test

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>

---------

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
7235294 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@noklam
Proposal of updated settings.py (#2587)
968d258 
* Proposal of updated settings.py

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Update settings after comment

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@rashidakanchwala
Collaborative Experiment Tracking Docs (#2589)
38e030a
@AhdraMeraliQB
Add metadata attribute to kedro.io datasets (#2537)
dc14f24 
* Add metadata attribute to kedro.io datasets

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
@tomasvanpottelbergh @stichbury @astrojuanlu
Update specs in pipeline hooks docstrings (#2598)
2c9fb4b 
* Update pipeline hooks docstrings

Signed-off-by: Tomas Van Pottelbergh <github@tomasvanpottelbergh.com>

* Acknowledge community contribution

---------

Signed-off-by: Tomas Van Pottelbergh <github@tomasvanpottelbergh.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu @stichbury
Miscellaneous hooks improvements (#2596)
41f03d9 
* Add debug level logging for hook execution order

Fix gh-1942.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Clarify role of setuptools in hooks

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Remove mentions to outdated and unused `pkg_resources`

Fix gh-2391.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Adapt example hook to spec signature

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Grammar and style fixes in docs

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Revert "Adapt example hook to spec signature"

This reverts commit ac1b495.

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@stichbury
Minor modification to titles of deployment docs to replace "deprecate…
7697dc4 
…d" with "legacy" (#2606)
@debugger24 @astrojuanlu
FIX: Typo in markdown for kedro notebooks docs (#2610)
2f248a4 
* FIX: Typo in markdown for kedro notebooks docs

Signed-off-by: debugger24 <rahulcomp24@gmail.com>

* Acknowledge community contribution

---------

Signed-off-by: debugger24 <rahulcomp24@gmail.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@noklam
Add the Kedro RichHandler (#2592)
4a4bd73 
* Add the Kedro RichHandler

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Clean up imports and comments

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Map arguments to add flexibility to customize arguments available in RichHandler

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Clean up rich_logger.py and unused imports

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Add docs - first iteration

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix imports and small refactoring

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Improve the doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Update the project's template

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* format docstring

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Apply Jo's comment on the doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix the link with RichHandler

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Apply suggestions from code review

Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>

* Fix broken doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* update template defaults

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* refactoring RichHandler and improve doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix broken test due to new default RichHandler

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Move kedro.extras.logging.RichHandler -> kedro.logging.RichHandler

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* add kedro/logging.py and remove the unnecessary import that cause namespace collision

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Refactor test

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Add more tests

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix lots of import, docstring

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Reorder docstring

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix tests

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Link options to doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Clean up doc and unused logger

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix spelling `customise`

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Refactor test with fixture

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Remove unnecessary copy() because it is now a fixture

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Split up test_rich_traceback_configuration() to smaller tests

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Add RELEASE.md

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Update doc

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* Fix template logging
@astrojuanlu @stichbury
Mention awesome-kedro in docs (#2620)
5d1e4c3 
* Mention awesome-kedro in docs

See kedro-org/kedro-devrel#40

* Update CONTRIBUTING.md

* Spelling and style fixes

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

---------

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@noklam @astrojuanlu
Update SnowparkTableDataSet docs (#2485)
8b2755c 
* Update SnowparkTableDataSet docs

* Add missing snowpark dependencies for docs building

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

---------

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@noklam @stichbury
Release 0.18.9 (#2619)
2fa1478 
* Update __init__.py

* Update release note

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* Update Version Numbers across docs

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* Update RELEASE.md

* Update Release Note

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@jmholzer @stichbury @astrojuanlu
Add documentation for deploying packaged Kedro projects on Databricks (…
c3c55ac 
…#2595)

* Add deployment workflow page

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add table of contents, entry point guide, data and conf upload guide

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add detailed instructions for creating a job on Databricks

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add images and automated deployment resources

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Remove use of 'allows', add summary

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Remove link to missing image

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add deployment workflow to toctree

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Lint and fix missing link

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Minor style, syntax and grammar improvements

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Fixes for correctness during validation

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add instructions for creating log output location

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Lint

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Lint databricks_run

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Minor wording change in reference to logs

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Modify reference to Pyspark-Iris

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Fix linter errors to enable docs build for inspection

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update build-docs.sh

* Fix broken link

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Remove spurious word

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Add advantages subheading

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Update docs/source/integrations/databricks_deployment_workflow.md

Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Add alternative ways to upload data to DBFS

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Move note on unpackaged config and data

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Fix broken links

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Move databricks back into deployment section

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Remove references to PySpark Iris (pyspark-iris) starter

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Graphics links fixes, revise titles

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Fix broken internal link

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Fix links broken by new folder

Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>

* Remove logs directory

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Update image of final job configuration

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Add full stops in list.

Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Fix conda environment name.

Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Modify wording and image for creating a new job cluster

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Modify wording in guide to create new job cluster

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

* Remove --upgrade option

Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* Add both ways of creating a new job

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>

---------

Signed-off-by: Jannic Holzer <jannic.holzer@quantumblack.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@tynandebold @Huongg @astrojuanlu
Update docs font family to Inter and swap the logo (#2611)
b7cd9b3 
* Update docs font family to Inter

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Match weights to previous Google font

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Update logo images; revert css formatting for easier PR review

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Update text styles

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Add trailing whitespace (?)

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Update Kedro image path

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* Update font size

Signed-off-by: Tynan DeBold <thdebold@gmail.com>

* update font to font-family: 'Inter', sans-serif;

Signed-off-by: huongg <huongg1409@gmail.com>

* testing with important for font-family

Signed-off-by: huongg <huongg1409@gmail.com>

* Make project name lowercase in docs

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>

* revert back to kedro/develop

Signed-off-by: huongg <huongg1409@gmail.com>

---------

Signed-off-by: Tynan DeBold <thdebold@gmail.com>
Signed-off-by: huongg <huongg1409@gmail.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Co-authored-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com>
Co-authored-by: huongg <huongg1409@gmail.com>
Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@merelcht
Enable variable interpolation for the catalog with OmegaConfigLoader (
f8230cd 
#2621)

* Enable variable interpolation in catalog by escaping _

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
stichbury and others added 4 commits June 2, 2023 16:39
@stichbury
Add archive link on docs home page (#2636)
d93532d 
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@noklam
Merge branch 'main' of github.com:kedro-org/kedro
ccff7b8 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
@ravi-kumar-pilla @stichbury
add ravi-kumar-pilla to tsc (#2629)
9a38a76 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
@noklam
Merge branch 'main' into feat/2520-info-log
151d5f8
@noklam noklam changed the base branch from main to develop June 5, 2023 14:50
@noklam noklam closed this Jun 5, 2023
@noklam noklam mentioned this pull request Jun 12, 2023
Closed
5 tasks
@noklam noklam deleted the feat/2520-info-log branch June 12, 2023 10:56
@noklam
Copy link
Contributor Author

noklam commented Jun 12, 2023

Replace by #2642, This was created from main instead of develop instead, so I closed it.

@noklam noklam mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yetudada yetudada Awaiting requested review from yetudada yetudada will be requested when the pull request is marked ready for review yetudada is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu will be requested when the pull request is marked ready for review astrojuanlu is a code owner

@merelcht merelcht Awaiting requested review from merelcht merelcht will be requested when the pull request is marked ready for review merelcht is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divorce config loader from logging.yml